Mark funtions returning Result as #[must_use]#13
Merged
RLado merged 1 commit intoRLado:masterfrom Mar 29, 2025
Merged
Conversation
…that the 'out' variable is not mutated
Owner
|
I just learned something new. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark functions returning Result as #[must_use], so that if the 'out' variable is not mutated, the program is sure to do something about it.
I realized that this case might be important if rsparse is used for e.g. robotic control where the output of e.g.
lusol, stored inbhere:lusol(a: &Sprs, b: &mut [T], order: i8, tol: T)may not have been touched, and could contain an invalid or otherwise dangerous solution. Previously, this would have been avoided by panicking, but now using Result introduces this possibility.